Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show user info with displayName and profile on version timeline #15233

Merged
merged 12 commits into from
Feb 23, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes User info missing for version timeline on entity pages

Screen.Recording.2024-02-17.at.1.18.07.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 17, 2024
@chirag-madlani chirag-madlani marked this pull request as ready for review February 20, 2024 12:04
@chirag-madlani chirag-madlani marked this pull request as draft February 20, 2024 12:07
@chirag-madlani chirag-madlani marked this pull request as ready for review February 20, 2024 12:07
@chirag-madlani chirag-madlani marked this pull request as draft February 20, 2024 12:12
@chirag-madlani chirag-madlani marked this pull request as ready for review February 20, 2024 12:12
@chirag-madlani chirag-madlani marked this pull request as draft February 20, 2024 14:55
Copy link

github-actions bot commented Feb 22, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.04% (31628/50984) 40.45% (12464/30812) 41.2% (3879/9414)

@chirag-madlani chirag-madlani marked this pull request as ready for review February 22, 2024 20:20
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

import { EntityType } from '../../constants/Entity.interface';
import { interceptURL, verifyResponseStatusCode } from '../common';

export const validateDomain = (domain: string, entityType: EntityType) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const validateDomain = (domain: string, entityType: EntityType) => {
export const validateVersion = (domain: string, entityType: EntityType) => {

@Sachin-chaurasiya Sachin-chaurasiya merged commit ad9a6df into main Feb 23, 2024
13 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the fix-version-user branch February 23, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Governance safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants