-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): show user info with displayName and profile on version timeline #15233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
UI specific issues
safe to test
Add this label to run secure Github workflows on PRs
labels
Feb 17, 2024
chirag-madlani
requested review from
harshach,
karanh37 and
Sachin-chaurasiya
as code owners
February 20, 2024 12:04
…penMetadata into fix-version-user
Quality Gate passed for 'open-metadata-ui'Issues Measures |
ShaileshParmar11
approved these changes
Feb 23, 2024
karanh37
approved these changes
Feb 23, 2024
Sachin-chaurasiya
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
import { EntityType } from '../../constants/Entity.interface'; | ||
import { interceptURL, verifyResponseStatusCode } from '../common'; | ||
|
||
export const validateDomain = (domain: string, entityType: EntityType) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
export const validateDomain = (domain: string, entityType: EntityType) => { | |
export const validateVersion = (domain: string, entityType: EntityType) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e:Governance
safe to test
Add this label to run secure Github workflows on PRs
UI
UI specific issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes User info missing for version timeline on entity pages
Screen.Recording.2024-02-17.at.1.18.07.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>