Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix the table row issue and make sample data table header fix #15268

Merged
merged 1 commit into from
Feb 20, 2024
Merged

MINOR: fix the table row issue and make sample data table header fix #15268

merged 1 commit into from
Feb 20, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 20, 2024 •
edited

Describe your changes:

  • fix the Entity Table row shifting issue.
  • Make Sample Data table header fix while scrolling

Issue :

Screen.Recording.2024-02-20.at.8.26.54.AM.mov

Resolved :

Screen.Recording.2024-02-20.at.5.35.42.PM.mov
Screen.Recording.2024-02-20.at.7.05.56.PM.mov
Screen.Recording.2024-02-20.at.5.36.47.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 20, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 20, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 20, 2024
@Ashish8689 Ashish8689 marked this pull request as ready for review February 20, 2024 12:16
@github-actions GitHub Actions
Copy link

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 61.58% (31404/51001) 40.46% (12502/30898) 40.98% (3861/9421)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 9c46391 into main Feb 20, 2024
22 of 27 checks passed
@Ashish8689 Ashish8689 deleted the table-page-fix branch February 20, 2024 13:24
Ashish8689 added a commit that referenced this pull request Feb 22, 2024
@Ashish8689
fix the table row issue and make sample data table header fix (#15268)
33dcc50 
(cherry picked from commit 9c46391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ashish8689 @chirag-madlani