Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: made ui enhancement in setting page #15269

Merged
merged 10 commits into from
Feb 23, 2024
Merged

MINOR: made ui enhancement in setting page #15269

merged 10 commits into from
Feb 23, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 20, 2024 •
edited

Describe your changes:

Issue #15305

  • fix the user page layout when no data is there
  • added button loader in test email button unless fetch is completed.

Issue :

image
Screen.Recording.2024-02-20.at.6.06.40.PM.mov

Resolved :

image
Screen.Recording.2024-02-20.at.6.04.17.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 20, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 20, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 62.08% (31718/51093) 40.47% (12478/30831) 41.27% (3888/9420)

@chirag-madlani chirag-madlani marked this pull request as ready for review February 21, 2024 11:54
@chirag-madlani chirag-madlani marked this pull request as draft February 21, 2024 11:55
@Ashish8689 Ashish8689 added the e2e This will trigger e2e test workflows label Feb 22, 2024
@Ashish8689 Ashish8689 marked this pull request as ready for review February 22, 2024 06:23
ShaileshParmar11
ShaileshParmar11 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

...i/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/TestSuiteIngestion.tsx Outdated Show resolved Hide resolved
...ata-ui/src/main/resources/ui/src/components/Settings/Email/TestEmail/TestEmail.component.tsx Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

@Sachin-chaurasiya @ShaileshParmar11 changes made as per comments!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 1efbeb1 into main Feb 23, 2024
15 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the minor-ui-fixes branch February 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ashish8689 @Sachin-chaurasiya @ShaileshParmar11 @chirag-madlani