Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: throw error message on test email config failure #15311

Merged
merged 1 commit into from
Feb 22, 2024
Merged

MINOR: throw error message on test email config failure #15311

merged 1 commit into from
Feb 22, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 22, 2024 •
edited

Describe your changes:

  • throw error message on while Testing email configuraion
Screen.Recording.2024-02-22.at.4.13.28.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Feb 22, 2024
@Ashish8689 Ashish8689 marked this pull request as ready for review February 22, 2024 10:45
@Ashish8689 Ashish8689 requested a review from a team as a code owner February 22, 2024 10:45
@Ashish8689 Ashish8689 changed the title throw error message on test email config failure MINOR: throw error message on test email config failure Feb 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 3adc1e5 into main Feb 22, 2024
22 of 32 checks passed
@Ashish8689 Ashish8689 deleted the smtp-config-failure branch February 22, 2024 12:47
Ashish8689 added a commit that referenced this pull request Feb 22, 2024
@Ashish8689
throw error message on test email config failure (#15311)
2e81553 
(cherry picked from commit 3adc1e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees

@Ashish8689 Ashish8689

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ashish8689 @Sachin-chaurasiya @mohityadav766