Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Pin pandas version to 2.0.x for Databricks client #15333

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 23, 2024

Describe your changes:

Why not use databricks-sql-python 3.0
databricks-sql-python==3.0 has a dependency on sqlalchemy 2.x.x . We'll be able to migrate to this library version when upgrading to sqlalchemy 2.x.x.

In the meantime we'll keep using 2.9.x and pin pandas to 2.1.x as recommended in this issue

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner February 23, 2024 14:02
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 23, 2024
@TeddyCr TeddyCr enabled auto-merge (squash) February 23, 2024 14:03
@TeddyCr TeddyCr changed the title MINOR - Pin pandas version to 2.1.x for Databricks client MINOR - Pin pandas version to 2.0.x for Databricks client Feb 23, 2024
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit 16fdc24 into open-metadata:main Feb 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants