Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add edit alert form item improvements #15346

Merged
merged 17 commits into from
Feb 28, 2024
Merged

Minor: Add edit alert form item improvements #15346

merged 17 commits into from
Feb 28, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Feb 26, 2024 •
edited

I worked on the following:

  • Change add alert form section names from "Trigger" -> "Source" and "Actions" -> "Trigger"
Screenshot 2024-02-26 at 7 12 29 PM
  • Show only "Owners" and "Assignees" options for the "Task" source. And do not show "Assignees" option for other sources.
Screen.Recording.2024-02-27.at.11.19.55.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Feb 26, 2024
@aniketkatkar97 aniketkatkar97 requested a review from a team February 26, 2024 13:26
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 26, 2024
@github-actions github-actions bot added backend e2e:Observability safe to test Add this label to run secure Github workflows on PRs and removed backend labels Feb 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 62.12% (31804/51198) 40.5% (12491/30842) 41.28% (3896/9439)

@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review February 27, 2024 10:10
@cypress Cypress
Copy link

cypress bot commented Feb 27, 2024 •
edited

1 failed test on run #33228 ↗︎

1 127 1 0 Flakiness 0

Details:

update the changed key value for other languages
Project: openmetadata Commit: e5554c2fac
Status: Failed Duration: 17:06 💡
Started: Feb 27, 2024 2:46 PM Ended: Feb 27, 2024 3:03 PM
Failed  cypress/e2e/Pages/DataInsightSettings.spec.js • 1 failed test • cypress-ci-mysql-pr-8066366651-1

View Output Video

Test Artifacts
Data Insight settings page should work properly > Deploy & run application Screenshots Video

Review all test suite changes for PR #15346 ↗︎

chirag-madlani
chirag-madlani previously approved these changes Feb 27, 2024
View reviewed changes
ShaileshParmar11
ShaileshParmar11 reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
12.2% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 0a38334 into main Feb 28, 2024
47 of 53 checks passed
@chirag-madlani chirag-madlani deleted the alert-improvements-ui branch February 28, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@aniketkatkar97 aniketkatkar97

Labels
backend e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aniketkatkar97 @chirag-madlani @ShaileshParmar11 @mohityadav766