Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 15839: More accurate documentation about setting up Secret Manager in Azure #16000

Merged
merged 2 commits into from Apr 24, 2024

Conversation

Nemeczek
Copy link
Contributor

@Nemeczek Nemeczek commented Apr 23, 2024

Describe your changes:

Fixes 15839

It is possible to use Azure Key Vault as Secrets Manager but the docs needed few more pointers. If you don't want to add this all boring stuff about Manged Identities then the updates YAML snippets should be enough.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pmbrull
Copy link
Collaborator

pmbrull commented Apr 24, 2024

thanks @Nemeczek for the help

@pmbrull pmbrull merged commit 207b5d9 into open-metadata:main Apr 24, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants