Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revamp announcement card #16016

Merged
merged 12 commits into from
Apr 30, 2024
Merged

revamp announcement card #16016

merged 12 commits into from
Apr 30, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Apr 24, 2024 •
edited
Loading

Describe your changes:

image image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Apr 24, 2024
@Ashish8689 Ashish8689 self-assigned this Apr 24, 2024
@github-actions github-actions bot added e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Apr 24, 2024
@cypress Cypress
Copy link

cypress bot commented Apr 24, 2024 •
edited
Loading

17 failed tests on run #34023 ↗︎

17 307 6 0 Flakiness 0

Details:

skip cypress failure due to flakiness
Project: openmetadata Commit: 8475fb7d97
Status: Failed Duration: 51:13 💡
Started: Apr 30, 2024 7:07 AM Ended: Apr 30, 2024 7:58 AM
Failed  Pages/Entity.spec.ts • 7 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Entity detail page > Dashboard page > GlossaryTerm assign, update & delete Screenshots Video
Entity detail page > Dashboard page > Soft delete Screenshots Video
Entity detail page > Pipeline page > Tags assign, update & delete Screenshots Video
Entity detail page > Pipeline page > GlossaryTerm assign, update & delete Screenshots Video
Entity detail page > Pipeline page > Soft delete Screenshots Video
Entity detail page > Container page > Tags assign, update & delete Screenshots Video
Entity detail page > Container page > Soft delete Screenshots Video
Failed  Pages/Database.spec.ts • 6 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Database hierarchy details page > Database page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Database page > Soft delete Screenshots Video
Database hierarchy details page > Database Schema page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Database Schema page > Soft delete Screenshots Video
Database hierarchy details page > Store Procedure page > GlossaryTerm assign, update & delete Screenshots Video
Database hierarchy details page > Store Procedure page > Soft delete Screenshots Video
Failed  Features/QueryEntity.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video
Query Entity > Verify query filter Screenshots Video
Failed  Pages/MyData.spec.ts • 2 failed tests • cypress-ci-mysql-pr-8890500697-1

View Output Video

Test Artifacts
My Data page > Verify user as owner feed widget Screenshots Video
My Data page > Verify team as owner feed widget Screenshots Video

Review all test suite changes for PR #16016 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.87% (34346/52948) 42.04% (13551/32235) 43.57% (4228/9704)

ShaileshParmar11
ShaileshParmar11 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add unit test for newly added component

...ata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedEditor/send-button.less Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

karanh37
karanh37 requested changes Apr 26, 2024
View reviewed changes
...-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCardBody.component.tsx Outdated Show resolved Hide resolved
...-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCardBody.component.tsx Outdated Show resolved Hide resolved
...-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCardBody.component.tsx Show resolved Hide resolved
...-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCardBody.component.tsx Outdated Show resolved Hide resolved
...ta-ui/src/main/resources/ui/src/components/Announcement/AnnouncementThreadBody.component.tsx Show resolved Hide resolved
...resources/ui/src/components/common/EntityPageInfos/AnnouncementDrawer/AnnouncementDrawer.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/ProfilePicture/ProfilePicture.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/styles/fonts.less Outdated Show resolved Hide resolved
...-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCardBody.component.tsx Outdated Show resolved Hide resolved
...data-ui/src/main/resources/ui/src/components/Announcement/AnnouncementFeedCard.component.tsx Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

@chirag-madlani @karanh37 changes made as per commets!

karanh37
karanh37 previously approved these changes Apr 30, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.6% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 89b083b into main Apr 30, 2024
11 of 15 checks passed
@Ashish8689 Ashish8689 deleted the announcement-revamp branch April 30, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani left review comments

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 karanh37 left review comments

@harshach harshach Awaiting requested review from harshach

Assignees

@Ashish8689 Ashish8689

Labels
e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ashish8689 @chirag-madlani @karanh37 @Sachin-chaurasiya @ShaileshParmar11