Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: rename the column to "Data quality", and updated space of the schema #16250

Merged
merged 4 commits into from
May 14, 2024
Merged

Minor: rename the column to "Data quality", and updated space of the schema #16250

merged 4 commits into from
May 14, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented May 14, 2024 •
edited

Describe your changes:

  • Rename column to "Data quality"
  • Updated column space
  • Shift column filter to left of the label
  • added missing filter of tags and glossary for Dashboard data modal and search index entity
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:DataAssets UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 14, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as draft May 14, 2024 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.78% (34747/53641) 41.61% (13696/32919) 43.55% (4261/9784)

@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review May 14, 2024 10:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented May 14, 2024

Passing run #34170 ↗︎

0 314 8 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'schema-tab-feedback' of https://github.com/open-metadata/OpenMetad...
Project: openmetadata Commit: 05f0e9c3c5
Status: Passed Duration: 59:30 💡
Started: May 14, 2024 10:36 AM Ended: May 14, 2024 11:36 AM

Review all test suite changes for PR #16250 ↗︎

@ShaileshParmar11 ShaileshParmar11 merged commit 75feb74 into main May 14, 2024
18 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the schema-tab-feedback branch May 14, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShaileshParmar11 @chirag-madlani