Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16232 - Fix Pagination Issues #16267

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

#16232 - Fix Pagination Issues #16267

wants to merge 7 commits into from

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented May 15, 2024

Describe your changes:

Fixes #16232

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this May 15, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner May 15, 2024 07:56
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label May 15, 2024
harshach
harshach previously approved these changes May 16, 2024
@pmbrull pmbrull changed the title - Fix Pagination Issues #16232 - Fix Pagination Issues May 16, 2024
@@ -293,3 +293,6 @@ delete from QRTZ_JOB_DETAILS;
delete from QRTZ_FIRED_TRIGGERS;

DELETE from event_subscription_entity where name = 'ActivityFeedAlert';

ALTER TABLE glossary_term_entity ADD COLUMN fullyQualifiedName VARCHAR(768) GENERATED ALWAYS AS (json ->> '$.fullyQualifiedName') NOT NULL;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshach will this cause issue for ASCII_BIN Collation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend customer safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GlossaryTerm] Issue in Listing Glossary Term with Same Name under different Glossary
3 participants