Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: fixed join and leave team issue #16287

Merged
merged 1 commit into from
May 15, 2024
Merged

Minor: fixed join and leave team issue #16287

merged 1 commit into from
May 15, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented May 15, 2024 •
edited

Team page was showing incorrect data after joining/leaving team

Before:

Screen.Recording.2024-05-15.at.7.24.46.PM.mov

After:

Screen.Recording.2024-05-15.at.10.03.28.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Settings safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels May 15, 2024
@github-actions GitHub Actions
Copy link

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.75% (34753/53671) 41.57% (13697/32952) 43.57% (4265/9788)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 8050716 into main May 15, 2024
14 of 16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the joine-team-btn-issue branch May 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShaileshParmar11 @chirag-madlani