Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16322 - Delete results on test case hard deletion #16500

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fixes #16322 - Delete results on test case hard deletion #16500

merged 2 commits into from
Jun 3, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented May 31, 2024

Describe your changes:

Fixes #16322

  • Delete results on hard deletion of test case

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner May 31, 2024 15:40
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels May 31, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit fda7c94 into open-metadata:main Jun 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete TestCase (is not completely eliminated)
3 participants
@TeddyCr @harshach @mohityadav766