Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: updated entity spec with custom property test #16621

Merged
merged 5 commits into from
Jun 12, 2024
Merged

playwright: updated entity spec with custom property test #16621

merged 5 commits into from
Jun 12, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jun 12, 2024 •
edited
Loading

Describe your changes:

Remove sample data dependency for custom property

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:Integration e2e:DataAssets UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jun 12, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.18% (35156/53940) 41.97% (13897/33109) 43.95% (4317/9823)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit af88b61 into main Jun 12, 2024
13 of 15 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the pw-custom-property branch June 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:DataAssets e2e:Integration safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShaileshParmar11 @chirag-madlani @Sachin-chaurasiya