Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: added exclude_defaults=False for profiler and deploy on airflow-apis #16734

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Jun 20, 2024

Describe your changes:

With the Pydantic v2 migration our model_dump_json sets exclude_defaults=True as a default.
This is breaking the Profile workflow if configured through the UI.

In order to fix it I'm explicitely passing exclude_defaults=False but we should discuss if we should change the default behaviour of the method.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jun 20, 2024
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ulixius9 ulixius9 merged commit 34f6f81 into open-metadata:main Jun 21, 2024
12 of 13 checks passed
@IceS2 IceS2 deleted the fix-model-dump-json-defaults branch June 21, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants