Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DuplicateLogin] User name issue for loggedInUserApi #16762

Merged
merged 16 commits into from
Jun 24, 2024
Merged

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Jun 21, 2024

Describe your changes:

Fixes #13470

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Jun 21, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner June 21, 2024 12:48
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jun 21, 2024
@mohityadav766
Copy link
Contributor Author

mohityadav766 commented Jun 21, 2024

@chirag-madlani can you check here for UI side
, we are removing support for username based login

@mohityadav766 mohityadav766 changed the title [DuplicateLogin] User name issue fixed for loggedInUserApi [DuplicateLogin] User name issue for loggedInUserApi Jun 21, 2024
sushi30
sushi30 previously approved these changes Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 23, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.2% (35283/54118) 41.98% (13962/33258) 43.98% (4332/9849)

Copy link

cypress bot commented Jun 23, 2024

Passing run #34493 ↗︎

0 541 421 0 Flakiness 0

Details:

fix sonar
Project: openmetadata Commit: ae035d8db0
Status: Passed Duration: 24:03 💡
Started: Jun 24, 2024 11:09 AM Ended: Jun 24, 2024 12:33 PM

Review all test suite changes for PR #16762 ↗︎

Copy link

sonarcloud bot commented Jun 24, 2024

Copy link

sonarcloud bot commented Jun 24, 2024

@mohityadav766 mohityadav766 merged commit b05d29c into main Jun 24, 2024
23 of 25 checks passed
@mohityadav766 mohityadav766 deleted the username-fix branch June 24, 2024 12:51
mohityadav766 added a commit that referenced this pull request Jun 24, 2024
* User Email Based lookup for loggedInUser

* Add Unique on name

* support email only login

* fix cypress

* fix playwright

* reset user for 404
inject enableSelfSignup for auth config

* Add Self Signup Flag

* Add error messages

* Better check

* Change to Custom Exception Message

* Update message as suggested

* fix claim issue for confidential type

* fix sonar

---------

Co-authored-by: Chira Madlani <chirag@getcollate.io>

(cherry picked from commit b05d29c)
akash-jain-10 pushed a commit that referenced this pull request Jun 25, 2024
* User Email Based lookup for loggedInUser

* Add Unique on name

* support email only login

* fix cypress

* fix playwright

* reset user for 404
inject enableSelfSignup for auth config

* Add Self Signup Flag

* Add error messages

* Better check

* Change to Custom Exception Message

* Update message as suggested

* fix claim issue for confidential type

* fix sonar

---------

Co-authored-by: Chira Madlani <chirag@getcollate.io>
(cherry picked from commit b05d29c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nameHash conflict for users with different mail
6 participants