Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display inspection query #16766

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Display inspection query #16766

merged 4 commits into from
Jun 25, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jun 23, 2024 •
edited
Loading

Describe your changes:

https://github.com/open-metadata/openmetadata-collate/issues/481

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Observability safe to test Add this label to run secure Github workflows on PRs labels Jun 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.21% (35312/54148) 42.01% (13960/33231) 44% (4336/9855)

@cypress Cypress
Copy link

cypress bot commented Jun 23, 2024 •
edited
Loading

Passing run #34499 ↗︎

0 76 0 0 Flakiness 0

Details:

fixed test failure
Project: openmetadata Commit: 5054cf17ea
Status: Passed Duration: 09:05 💡
Started: Jun 24, 2024 5:57 PM Ended: Jun 24, 2024 6:06 PM

Review all test suite changes for PR #16766 ↗︎

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 self-assigned this Jun 25, 2024
@ShaileshParmar11 ShaileshParmar11 merged commit 04d3720 into main Jun 25, 2024
16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the data-insight-sql-query-tab branch June 25, 2024 05:39
harshach pushed a commit that referenced this pull request Jun 30, 2024
@ShaileshParmar11 @harshach
Display inspection query (#16766)
402a351 
* Display inspection query

* added reset for global state

* fixed test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShaileshParmar11 @karanh37 @aniketkatkar97