Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR removed __init__ in cli module for namespace path #16775

Merged
merged 1 commit into from
Jun 25, 2024
Merged

MINOR removed __init__ in cli module for namespace path #16775

merged 1 commit into from
Jun 25, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Jun 24, 2024

Describe your changes:

  • remove __init__.py to allow namespace package in cli module

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested a review from a team as a code owner June 24, 2024 14:35
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jun 24, 2024
@TeddyCr TeddyCr enabled auto-merge (squash) June 24, 2024 14:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit d38194f into open-metadata:main Jun 25, 2024
15 checks passed
harshach pushed a commit that referenced this pull request Jun 30, 2024
@TeddyCr @harshach
fix: removed __init__ in cli module for namespace path (#16775)
a19c5a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi30 sushi30 sushi30 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TeddyCr @sushi30