Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: fixed testSummaryGraph issue #17115

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Minor: fixed testSummaryGraph issue #17115

merged 1 commit into from
Jul 22, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jul 21, 2024 •
edited
Loading

issue: area graph throwing undefined error due to inaccurate data.

before:
image

after:
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jul 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@ShaileshParmar11 ShaileshParmar11 self-assigned this Jul 21, 2024
@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Jul 21, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review July 21, 2024 10:19
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.48% (36086/55114) 41.99% (14255/33945) 43.93% (4389/9992)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 21, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jul 21, 2024

1 failed test on run #34604 ↗︎

1 389 16 0 Flakiness 0

Details:

Minor: fixed testSummaryGraph issue
Project: openmetadata Commit: 06e1b385b9
Status: Failed Duration: 03:01 💡
Started: Jul 21, 2024 10:39 AM Ended: Jul 21, 2024 11:42 AM
Failed  cypress/e2e/Pages/DataInsight.spec.ts • 1 failed test • cypress-ci-mysql-pr-10027552743-1

View Output Video

Test Artifacts
Data Insight feature > Verifying App analytics tab Screenshots Video

Review all test suite changes for PR #17115 ↗︎

@ShaileshParmar11 ShaileshParmar11 merged commit 00278ce into main Jul 22, 2024
28 of 39 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the test-case-graph-bug branch July 22, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShaileshParmar11 @chirag-madlani