Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access control rule userRoleAttr to point to roleName #2644

Merged
merged 1 commit into from Feb 20, 2022

Conversation

mithmatt
Copy link
Collaborator

@mithmatt mithmatt commented Feb 7, 2022

Describe your changes :

I worked on this to fix the schema documentation

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Backend: @sureshms @harshach

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@harshach
Copy link
Collaborator

harshach commented Feb 7, 2022

@mithmatt these seems to be new failures
image

@mithmatt
Copy link
Collaborator Author

mithmatt commented Feb 7, 2022

@mithmatt these seems to be new failures image

#2647 2647

@mithmatt mithmatt self-assigned this Feb 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 20, 2022

LGTM! Just one thing, before merging let's double-check the core package version as there are other PRs bumping it as well

@mithmatt
Copy link
Collaborator Author

mithmatt commented Feb 20, 2022

LGTM! Just one thing, before merging let's double-check the core package version as there are other PRs bumping it as well

Yes, all PRs going in after this would need to rebase...

@mithmatt mithmatt merged commit 5419366 into open-metadata:main Feb 20, 2022
@mithmatt mithmatt deleted the fix_user_role branch February 20, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants