Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tableau Lineage Implementation #2850

Merged
merged 2 commits into from Feb 19, 2022
Merged

Tableau Lineage Implementation #2850

merged 2 commits into from Feb 19, 2022

Conversation

ayush-shah
Copy link
Member

Describe your changes :

Worked on #2765

Type of change :

  • New feature

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach @pmbrull

@ayush-shah ayush-shah added this to In progress in Release 0.9.0 via automation Feb 18, 2022
@ayush-shah ayush-shah self-assigned this Feb 18, 2022
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks great!

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harshach
Copy link
Collaborator

@ayush-shah @pmbrull we should create util function that can return a table_fqdn.
We may have to change this logic in this release or next release as we are discussing about adding database.schema.table_name into the mix. If that happens then we need to change this parsing multiple places. It would be better to have this in a central place where we can add necessary changes

@ayush-shah
Copy link
Member Author

@ayush-shah @pmbrull we should create util function that can return a table_fqdn. We may have to change this logic in this release or next release as we are discussing about adding database.schema.table_name into the mix. If that happens then we need to change this parsing multiple places. It would be better to have this in a central place where we can add necessary changes

Should we create a new ticket to keep track of the same and merge this PR?

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 19, 2022

@ayush-shah @pmbrull we should create util function that can return a table_fqdn. We may have to change this logic in this release or next release as we are discussing about adding database.schema.table_name into the mix. If that happens then we need to change this parsing multiple places. It would be better to have this in a central place where we can add necessary changes

Should we create a new ticket to keep track of the same and merge this PR?

@ayush-shah yeah let's open a separate issue and merge this in for now. Thanks!

@harshach harshach merged commit 0e34028 into main Feb 19, 2022
@harshach harshach deleted the tableau-ingestion branch February 19, 2022 17:15
Release 0.9.0 automation moved this from In progress to Done Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants