Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Constraints Added - Ingestion #2854

Merged
merged 8 commits into from Feb 19, 2022
Merged

Table Constraints Added - Ingestion #2854

merged 8 commits into from Feb 19, 2022

Conversation

ayush-shah
Copy link
Member

Describe your changes :

Added TableConstraints for PrimaryKeys if there are more than 1 in a table

Type of change :

  • Bug fix
  • Improvement

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach @pmbrull

@ayush-shah ayush-shah self-assigned this Feb 18, 2022
@ayush-shah ayush-shah added this to In progress in Release 0.9.0 via automation Feb 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harshach harshach merged commit d2c6400 into main Feb 19, 2022
@harshach harshach deleted the table-constraint branch February 19, 2022 17:16
Release 0.9.0 automation moved this from In progress to Done Feb 19, 2022
@ayush-shah ayush-shah mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

Assignees

@ayush-shah ayush-shah

Labels
Ingestion
Projects
No open projects
Release 0.9.0
Done
Milestone
Milestone 3 - 0.9.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ayush-shah @harshach