Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #2521 - Add owner support for all services and database #2858

Merged
merged 2 commits into from Feb 19, 2022
Merged

Fix: #2521 - Add owner support for all services and database #2858

merged 2 commits into from Feb 19, 2022

Conversation

darth-coder00
Copy link
Contributor

Describe your changes :

I worked on the service and database pages to add support to set owner

Type of change :

  • Bug fix
  • Improvement

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@Sachin-chaurasiya @shahsank3t

@darth-coder00 darth-coder00 self-assigned this Feb 19, 2022
@darth-coder00 darth-coder00 added this to In progress in Release 0.9.0 via automation Feb 19, 2022
Sachin-chaurasiya
Sachin-chaurasiya approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@darth-coder00 Please Resolve the conflicts.

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya Sachin-chaurasiya merged commit 5ecf980 into main Feb 19, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-2521 branch February 19, 2022 11:29
Release 0.9.0 automation moved this from In progress to Done Feb 19, 2022
@Sachin-chaurasiya Sachin-chaurasiya mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@darth-coder00 darth-coder00

Labels
None yet
Projects
No open projects
Release 0.9.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darth-coder00 @Sachin-chaurasiya