Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat collaboration #2859

Merged
merged 96 commits into from Feb 28, 2022
Merged

Feat collaboration #2859

merged 96 commits into from Feb 28, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Feb 19, 2022 •
edited

Closes #2723
Closes #2722
Closes #2721

Describe your changes :

  • Create an "Activity Feed" tab and added support for posting feed from the following entities page

    • Table
    • Topic
    • dashboard
    • pipeline
    • database
    • services
      • database
      • message
      • dashboard
      • pipeline

  • Show "Activity Feed" in the homepage from threads

    • If no feed data is available showing OnBoarding Message
    • Secure Mode - Showing Logged In user's feeds
    • Non-Secure Mode - Showing all feeds
    • support for posting a reply

  • Add Panel to show the threads and posts under them 

    • Integrate API in the panel to get thread data by thread id.

  • Add UI support for showing the latest 3 replies with indentation.

    • Integrate API to get the entityThread with the latest 3 replies/posts

  • Add Rich Text Editor

    • Bold
    • Italic
    • Strikethrough
    • Quote
    • Code Block
    • List
      • ordered
      • unordered
    • Link

  • Add support for posting a reply on Enter

  • Add support for closing side panel on the Escape key

Type of change :

  • New feature

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Feb 19, 2022
@Sachin-chaurasiya Sachin-chaurasiya changed the title Feat collaboration [WIP] Feat collaboration Feb 19, 2022
This was linked to issues Feb 19, 2022
UI: Create an "Activity Feed" tab for all the pages to show all the threads related to that entity #2722
Closed
UI: Show "Activity Feed" in the homepage from threads #2723
Closed
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft February 25, 2022 07:13
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review February 25, 2022 13:31
darth-coder00
darth-coder00 approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

[catalog-rest-service] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 9 Bugs
Vulnerability D 2 Vulnerabilities
Security Hotspot E 9 Security Hotspots
Code Smell A 730 Code Smells

69.1% 69.1% Coverage
5.9% 5.9% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harshach harshach merged commit a68667c into main Feb 28, 2022
@harshach harshach deleted the feat-collaboration branch February 28, 2022 19:41
@Sachin-chaurasiya Sachin-chaurasiya restored the feat-collaboration branch March 1, 2022 03:37
@Sachin-chaurasiya Sachin-chaurasiya deleted the feat-collaboration branch March 1, 2022 03:37
@Sachin-chaurasiya Sachin-chaurasiya restored the feat-collaboration branch March 1, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-coder00 darth-coder00 darth-coder00 approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

@vivekratnavel vivekratnavel Awaiting requested review from vivekratnavel

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Sachin-chaurasiya @darth-coder00 @harshach