Fix #2867: Add support for GET /feed/{id} #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mithmatt
reviewed
Feb 21, 2022
catalog-rest-service/src/main/java/org/openmetadata/catalog/Entity.java
Outdated
Show resolved
Hide resolved
catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/feeds/FeedResource.java
Show resolved
Hide resolved
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
|
[catalog] Kudos, SonarCloud Quality Gate passed! |
mithmatt
reviewed
Feb 21, 2022
| content = @Content(mediaType = "application/json", schema = @Schema(implementation = PostList.class))), | ||
| }) | ||
| public PostList getPosts(@Context UriInfo uriInfo, @PathParam("id") String id) throws IOException { | ||
| return new PostList(dao.listPosts(id)); |
There was a problem hiding this comment.
I presume we do not have href for posts.
There was a problem hiding this comment.
That is correct
mithmatt
approved these changes
Feb 21, 2022
|
@mithmatt Thank you for the review! |
Sachin-chaurasiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
See #2867
Type of change :
Checklist:
Reviewers