Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2871: Make search magnifying glass clickable to search #2923

Merged
merged 2 commits into from Feb 23, 2022
Merged

Fix #2871: Make search magnifying glass clickable to search #2923

merged 2 commits into from Feb 23, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Feb 22, 2022 •
edited

Closes #2871

Describe your changes :

see #2871

Type of change :

  • Improvement

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Feb 22, 2022
darth-coder00
darth-coder00 suggested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments

openmetadata-ui/src/main/resources/ui/src/components/app-bar/Appbar.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/tour-page/TourPage.component.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/tour-page/TourPage.component.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/nav-bar/NavBar.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

93.5% 93.5% Coverage
0.0% 0.0% Duplication

darth-coder00
darth-coder00 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darth-coder00 darth-coder00 merged commit ba97b40 into main Feb 23, 2022
@darth-coder00 darth-coder00 deleted the issue-2871 branch February 23, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-coder00 darth-coder00 darth-coder00 approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make search magnifying glass clickable to search
2 participants
@Sachin-chaurasiya @darth-coder00