Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing selenium version #2934

Merged

Conversation

kshinde2512
Copy link
Contributor

Describe your changes :

Changed selenium version to 4.1.1

Type of change :

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@darth-coder00 @shahsank3t

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

46.7% 46.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darth-coder00 darth-coder00 merged commit b570d52 into open-metadata:main Feb 23, 2022
@darth-coder00
Copy link
Contributor

@kshinde2512 Can we link the open ticket for version change here?

@kshinde2512
Copy link
Contributor Author

Issue for this PR
#2909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants