Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #2938 Remove serviceType from service UI route #2939

Merged
merged 7 commits into from Feb 28, 2022
Merged

Fix: #2938 Remove serviceType from service UI route #2939

merged 7 commits into from Feb 28, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Feb 23, 2022 •
edited

Closes #2938

Describe your changes :

See #2938

Type of change :

  • Improvement

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Feb 23, 2022
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review February 23, 2022 07:11
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

darth-coder00
darth-coder00 reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sachin-chaurasiya, Added some queries

...etadata-ui/src/main/resources/ui/src/pages/EntityVersionPage/EntityVersionPage.component.tsx Show resolved Hide resolved
...etadata-ui/src/main/resources/ui/src/pages/EntityVersionPage/EntityVersionPage.component.tsx Show resolved Hide resolved
darth-coder00
darth-coder00 approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harshach harshach merged commit 22393c2 into main Feb 28, 2022
@harshach harshach deleted the issue-2938 branch February 28, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-coder00 darth-coder00 darth-coder00 approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI : Remove serviceType from service UI route
3 participants
@Sachin-chaurasiya @darth-coder00 @harshach