Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2942 - Fix bugs reported by Sonar issue on release 0.9 #2943

Merged
merged 1 commit into from Feb 24, 2022
Merged

Fixes #2942 - Fix bugs reported by Sonar issue on release 0.9 #2943

merged 1 commit into from Feb 24, 2022

Conversation

sureshms
Copy link
Contributor

Describe your changes :

See #2942 for more details

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

mithmatt
mithmatt reviewed Feb 23, 2022
View reviewed changes
...ervice/src/main/java/org/openmetadata/catalog/resources/permissions/PermissionsResource.java Outdated
@@ -38,7 +37,7 @@
public class PermissionsResource {
private final Authorizer authorizer;

public PermissionsResource(CollectionDAO dao, @NonNull Authorizer authorizer) {
public PermissionsResource(@NonNull Authorizer authorizer) {
Copy link
Collaborator

@mithmatt mithmatt Feb 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in runtime error from CollectionRegistry to register this resource, since it looks for constructor with two args in the order CollectionDAO and Authorizer

This does not fail during compile time..

I should have left a comment here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-metadata/OpenMetadata/blob/main/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/CollectionRegistry.java#L202

Copy link
Contributor Author

@sureshms sureshms Feb 24, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay reverted that change with suppressing unused warning annotation...

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[catalog-rest-service] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 9 Bugs
Vulnerability D 2 Vulnerabilities
Security Hotspot E 9 Security Hotspots
Code Smell A 730 Code Smells

69.1% 69.1% Coverage
5.9% 5.9% Duplication

@sureshms
Copy link
Contributor Author

SonarCloud issues are unrelated to this patch.

@sureshms sureshms merged commit 7ea9e44 into main Feb 24, 2022
@sureshms sureshms deleted the 2942 branch February 24, 2022 04:40
sureshms added a commit that referenced this pull request Feb 24, 2022
@sureshms
Fixes #2962 - Fix bugs reported by Sonar issue on release 0.9 (#2943)
f0ff64d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithmatt mithmatt mithmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sureshms @mithmatt