Fix Okta Authentication and Validation - Ingestion #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshach
reviewed
Feb 24, 2022
harshach
reviewed
Feb 24, 2022
ayush-shah
force-pushed
the
issue-2953
branch
from
422f249
to
7df2dbc
Compare
harshach
reviewed
Feb 24, 2022
| @@ -155,7 +156,7 @@ def __init__(self, config: MetadataServerConfig, raw_data: bool = False): | |||
| base_url=self.config.api_endpoint, | |||
| api_version=self.config.api_version, | |||
| auth_header="Authorization", | |||
| auth_token=self._auth_provider.auth_token(), | |||
| auth_token=asyncio.run(self._auth_provider.auth_token()), | |||
There was a problem hiding this comment.
do we need aysncio here?
harshach
approved these changes
Feb 24, 2022
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
|
@harshach I have added the code that renews the tokens |
ayush-shah
added a commit
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
fixes #2953
fixes #2913
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers
@harshach @pmbrull @vivekratnavel