Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support returning teams for GET /roles #2958

Merged
merged 1 commit into from Feb 24, 2022

Conversation

mithmatt
Copy link
Collaborator

@mithmatt mithmatt commented Feb 23, 2022

Describe your changes :

See #2882

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Backend: @sureshms @harshach

@github-actions
Copy link

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@mithmatt mithmatt force-pushed the role_teams branch 2 times, most recently from 8ed683c to a6aab4d Compare February 23, 2022 22:41
@mithmatt mithmatt self-assigned this Feb 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mithmatt
Copy link
Collaborator Author

2022-02-23T23:57:52.3397266Z [INFO] 
2022-02-23T23:57:52.3529589Z [INFO] Results:
2022-02-23T23:57:52.3530837Z [INFO] 
2022-02-23T23:57:52.3549180Z [ERROR] Failures: 
2022-02-23T23:57:52.3550521Z [ERROR]   WebhookResourceTest.put_updateEndpointURL:179->EntityResourceTest.deleteEntity:1361->EntityResourceTest.deleteEntity:1371 Expected org.apache.http.client.HttpResponseException to be thrown, but nothing was thrown.
2022-02-23T23:57:52.3551062Z [INFO] 
2022-02-23T23:57:52.3551309Z [ERROR] Tests run: 890, Failures: 1, Errors: 0, Skipped: 0
2022-02-23T23:57:52.3551534Z [INFO] 

Flaky test

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

58.3% 58.3% Coverage
0.0% 0.0% Duplication

@sureshms sureshms merged commit a1257bd into open-metadata:main Feb 24, 2022
@mithmatt mithmatt deleted the role_teams branch February 24, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants