Fixes #2962 - Clean up fields parameter choices in GET APIs #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshach
approved these changes
Feb 24, 2022
mithmatt
reviewed
Feb 24, 2022
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| package org.openmetadata.catalog.resources.teams; | |||
|
|
|||
| import static java.util.List.*; | |||
mithmatt
reviewed
Feb 24, 2022
| for (EntityReference role : expectedRoles) { | ||
| TestUtils.existsInEntityReferenceList(user.getRoles(), role.getId(), true); | ||
| } | ||
| System.out.println("XXX expectedRoles " + expectedRoles); |
There was a problem hiding this comment.
Remove print statements?
| // Some fields are not set and hence are null - tested elsewhere | ||
| assertListNotNull( | ||
| pipeline.getOwner(), | ||
| /*pipeline.getTasks(), |
There was a problem hiding this comment.
That was to call out, we are not specifically testing those fields... :)
|
[catalog] Kudos, SonarCloud Quality Gate passed! |
sureshms
changed the title
mithmatt
approved these changes
Feb 26, 2022
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
See #2962 for more details
Type of change :
Checklist: