Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lombok Getter to simplify openmetadata-ui/*.java files #2975

Merged
merged 1 commit into from Feb 25, 2022

Conversation

mithmatt
Copy link
Collaborator

@mithmatt mithmatt commented Feb 24, 2022

Describe your changes :

See #2972

  • Use Getter for all the objects
  • Remove unused functions

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya

@mithmatt mithmatt marked this pull request as draft February 24, 2022 10:38
@github-actions
Copy link

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@mithmatt mithmatt marked this pull request as ready for review February 24, 2022 11:14
@mithmatt
Copy link
Collaborator Author

[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ openmetadata-ui ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 43 source files to /Users/matt/Documents/projects/open-metadata/OpenMetadata/openmetadata-ui/target/test-classes
[WARNING] /Users/matt/Documents/projects/open-metadata/OpenMetadata/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/events/Events.java: /Users/matt/Documents/projects/open-metadata/OpenMetadata/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/events/Events.java uses or overrides a deprecated API.
[WARNING] /Users/matt/Documents/projects/open-metadata/OpenMetadata/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/events/Events.java: Recompile with -Xlint:deprecation for details.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.639 s
[INFO] Finished at: 2022-02-24T03:14:48-08:00
[INFO] ------------------------------------------------------------------------

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shahsank3t shahsank3t merged commit 6dadbc1 into open-metadata:main Feb 25, 2022
@mithmatt mithmatt deleted the clean_up3 branch February 25, 2022 05:52
@mithmatt mithmatt mentioned this pull request Feb 25, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants