Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2996: ChangeEventHandler throws NPE at times #2998

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Fix #2996: ChangeEventHandler throws NPE at times #2998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59ef071
Fix #2996: ChangeEventHandler throws NPE at times
vivekratnavel Feb 26, 2022
94b6a09
Address review comments
vivekratnavel Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion catalog-rest-service/src/main/java/org/openmetadata/catalog/events/ChangeEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import javax.ws.rs.container.ContainerResponseContext;
import javax.ws.rs.core.Response.Status;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.StringUtils;
import org.jdbi.v3.core.Jdbi;
import org.openmetadata.catalog.CatalogApplicationConfig;
import org.openmetadata.catalog.Entity;
Expand Down Expand Up @@ -207,7 +208,7 @@ private List<Thread> getThreads(List<FieldChange> fields, Object entity, CHANGE_
String fieldName = field.getName();
String arrayFieldName = null;
String arrayFieldValue = null;
String newFieldValue = field.getNewValue().toString();
String newFieldValue = field.getNewValue() != null ? field.getNewValue().toString() : StringUtils.EMPTY;
if (fieldName.contains(".")) {
String[] fieldNameParts = fieldName.split("\\.");
// For array type, it should have 3 ex: columns.comment.description
Expand Down