Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Selenium fix #3014

Merged
merged 10 commits into from Mar 1, 2022
Merged

WIP - Selenium fix #3014

merged 10 commits into from Mar 1, 2022

Conversation

parthp2107
Copy link
Contributor

Describe your changes :

Fixing selenium tests

Type of change :

  • Bug fix
  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

@parthp2107 parthp2107 marked this pull request as draft February 28, 2022 13:46
pmbrull
pmbrull reviewed Feb 28, 2022
View reviewed changes
ingestion/setup.py Outdated
"db2": {"ibm-db-sa==0.3.7"},
"clickhouse": {"clickhouse-driver==0.2.3", "clickhouse-sqlalchemy==0.2.0"},
# "db2": {"ibm-db-sa==0.3.7"},
# "clickhouse": {"clickhouse-driver==0.2.3", "clickhouse-sqlalchemy==0.2.0"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be commented out? If the python CI was bringing issues, that has been fixed #3012

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will uncomment this before the final review. It was for testing.

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@parthp2107 parthp2107 marked this pull request as ready for review March 1, 2022 09:56
@shahsank3t shahsank3t merged commit 777c6c3 into main Mar 1, 2022
@shahsank3t shahsank3t deleted the selenium-fix branch March 1, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull left review comments

@shahsank3t shahsank3t shahsank3t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parthp2107 @shahsank3t @pmbrull