Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3012 - Dependency breaking Airflow Container #3015

Merged
merged 4 commits into from Feb 28, 2022

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Feb 28, 2022

Describe your changes :

This PR fixes #3012.

After a PR updating a plugin that required sqlalchemy>1.4, the python CI started to fail as the container could not properly start.

In this PR we are adding a new plugin to update airflow's dependencies based on sqlalchemy so that we can get it working with sqlalchemy 1.4. We fixed that version in the base requirements to use it for the profiler and other plugins.

Thanks

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull merged commit 00552f6 into open-metadata:main Feb 28, 2022
@pmbrull pmbrull deleted the issue-3012 branch February 28, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Python CI
2 participants