Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : Display a chat icon next to data entities that have threads #3026

Merged
merged 108 commits into from Mar 1, 2022
Merged

Feat : Display a chat icon next to data entities that have threads #3026

merged 108 commits into from Mar 1, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

Closes #2720

Describe your changes :

See issue #2720

Type of change :

  • New feature

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya
Fix #2778 UI : Add Queries tab for table details page.
0779e42
@Sachin-chaurasiya
minor change
139e317
@Sachin-chaurasiya
Changing Table Queries text to Queries.
fbfc807
@Sachin-chaurasiya
Addressing comments
cad67bf
@Sachin-chaurasiya
Merge branch 'main' into issue-2778
c8c2a1c
@Sachin-chaurasiya
Merge branch 'main' into issue-2778
ec7546e
@Sachin-chaurasiya
Adding last run by user detail
ff2a5fb
@Sachin-chaurasiya
Minor UI Changes
a4d7afe
@Sachin-chaurasiya
Merge branch 'main' into issue-2778
576c7c5
@Sachin-chaurasiya
Removed icon
a187a4e
@Sachin-chaurasiya
Changing Query card style.
5c0799f
@Sachin-chaurasiya
Changing Icons
3b939e2
@Sachin-chaurasiya
Merge branch 'main' into issue-2778
4eb78f1
@Sachin-chaurasiya
Merge branch 'main' into feat-collaboration
6dae479
@Sachin-chaurasiya
Adding activity feed tab in entity details page.
3a09c25
@Sachin-chaurasiya
Adding user feed on landing page.
7fccf0d
@Sachin-chaurasiya
Adding activity feed tab in topic entity page.
7c6c08c
@Sachin-chaurasiya
Adding activity feed tab in dashboard entity page.
4884432
@Sachin-chaurasiya
Fixing props issue in test file.
5c60bd0
@Sachin-chaurasiya
Adding activity feed tab in pipeline entity page.
32c63d5
@Sachin-chaurasiya
Merge branch 'main' into feat-collaboration
f338825
@Sachin-chaurasiya
Adding support for activity feed in non-secure mode.
a9147a8
@Sachin-chaurasiya
Adding avatar for 3 last replied users.
7c19f1f
@Sachin-chaurasiya
Adding more spacing between feed
df3894c
@Sachin-chaurasiya
Adding background to feed message.
936f9e5
@Sachin-chaurasiya
Changing background color for entity detail page.
9bb4fcf
@Sachin-chaurasiya
Merge branch 'main' into feat-collaboration
b0718f8
@Sachin-chaurasiya
Fixing height issue
36a425e
@Sachin-chaurasiya
Addding first UI implementation of Feed Side panel.
15a6afd
@Sachin-chaurasiya
Changing Initial state of sidepanel
c8df960
@Sachin-chaurasiya
Fix failing test
4768732
@Sachin-chaurasiya
Fix: UI Display a chat icon next to data entities that have threads.
db63c30
@Sachin-chaurasiya
Add support for showing chat buuble in table entity.
d91833e
@Sachin-chaurasiya
Add support for create new thread
84e9341
@Sachin-chaurasiya
Add support for showing chat bubble in topic entity.
82f9d6e
@Sachin-chaurasiya
Add support for showing chat bubble in dashboard entity.
805be9f
@Sachin-chaurasiya
Add support for showing chat bubble in pipeline entity.
71ba6fb
@Sachin-chaurasiya
Minor style tweak.
e3adcd8
@Sachin-chaurasiya
Fixing failing test
6be89eb
@Sachin-chaurasiya
Fix reply CTA to go thread detail.
3e9d884
@Sachin-chaurasiya
Change default avatar type to square.
f6a2316
@Sachin-chaurasiya
change setup.py code
5d4da0e
@Sachin-chaurasiya
Minor tweak.
5eba9ce
@Sachin-chaurasiya
Merge branch 'main' into feat-collaboration
f2c0c9f
@Sachin-chaurasiya
Reverting change setup.py code
49bb575
@Sachin-chaurasiya
Add chrome option
2f6331b
@Sachin-chaurasiya
Change setup.py code
adc113e
@Sachin-chaurasiya
@Sachin-chaurasiya
703466f 
Reverting change setup.py code
@Sachin-chaurasiya
Remove chrome option
6475f8c
@Sachin-chaurasiya
Revert setup.py change
ea57f84
@Sachin-chaurasiya
Merge branch 'main' into feat-collaboration
974a714
@Sachin-chaurasiya
Merge branch 'feat-collaboration' into feat-entityThread
a3c8a7f
@Sachin-chaurasiya
Merge branch 'main' into feat-entityThread
b629fb3
@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Mar 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

darth-coder00
darth-coder00 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darth-coder00 darth-coder00 merged commit 642f875 into main Mar 1, 2022
@darth-coder00 darth-coder00 deleted the feat-entityThread branch March 1, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-coder00 darth-coder00 darth-coder00 approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Display a chat icon next to data entities that have threads
2 participants
@Sachin-chaurasiya @darth-coder00