Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3035: handled none entity #3036

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix #3035: handled none entity #3036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 15 additions & 10 deletions ingestion/src/metadata/ingestion/source/metabase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ def get_lineage(self, chart_list, dashboard_name):
for chart in chart_list:
try:
chart_details = chart["card"]
if not chart_details.get("table_id"):
continue
resp_tables = self.req_get(f"/api/table/{chart_details['table_id']}")
if resp_tables.status_code == 200:
table = resp_tables.json()
Expand All @@ -229,17 +231,18 @@ def get_lineage(self, chart_list, dashboard_name):
entity=Model_Dashboard, fqdn=dashboard_fqdn
)
logger.debug("from entity %s", table_entity)
lineage = AddLineageRequest(
edge=EntitiesEdge(
fromEntity=EntityReference(
id=table_entity.id.__root__, type="table"
),
toEntity=EntityReference(
id=chart_entity.id.__root__, type="dashboard"
),
if table_entity and chart_entity:
lineage = AddLineageRequest(
edge=EntitiesEdge(
fromEntity=EntityReference(
id=table_entity.id.__root__, type="table"
),
toEntity=EntityReference(
id=chart_entity.id.__root__, type="dashboard"
),
)
)
)
yield lineage
yield lineage
except Exception as err: # pylint: disable=broad-except,unused-variable
logger.error(traceback.print_exc())

Expand All @@ -264,6 +267,8 @@ def get_card_detail(self, card_list):
for card in card_list:
try:
card_details = card["card"]
if not card_details.get("id"):
continue
card_detail_resp = self.req_get(f"/api/card/{card_details['id']}")
if card_detail_resp.status_code == 200:
card = card_detail_resp.json()
Expand Down