Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3040 - py_format recipe includes more paths #3043

Merged
merged 1 commit into from Mar 1, 2022

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Mar 1, 2022

Describe your changes :

This PR fixes #3040

We were missing checks on tests and examples directories. This PR updates the recipes to include everything but generated in the formatting rules.

Thanks

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@pmbrull pmbrull requested a review from amiorin March 1, 2022 13:30
@pmbrull pmbrull merged commit 01a975e into open-metadata:main Mar 1, 2022
@pmbrull pmbrull deleted the issue-3040 branch March 1, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Py format to pick up tests
2 participants