Fix #3067: Service Creation should only be done by Bots or admins and Update only by the owners

[harshach]

Describe your changes :

See #3067

Type of change :

• Bug fix

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

• I have read the CONTRIBUTING document.
• I have performed a self-review of my own.
• I have tagged my reviewers below.
• I have commented on my code, particularly in hard-to-understand areas.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• All new and existing tests passed.

Reviewers

[sonarcloud]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[mithmatt]

@harshach

Need to update test error message assertions

2022-03-02T07:54:21.1641509Z [INFO] Results:
2022-03-02T07:54:21.1642110Z [INFO] 
2022-03-02T07:54:21.1642377Z [ERROR] Failures: 
2022-03-02T07:54:21.1645041Z [ERROR]   DashboardServiceResourceTest>EntityResourceTest.put_entityUpdate_as_non_owner_4xx:924 expected: <Principal: CatalogPrincipal{name='test'} does not have permissions> but was: <Principal: CatalogPrincipal{name='test'} is not admin>
2022-03-02T07:54:21.1655072Z [ERROR]   DatabaseServiceResourceTest>EntityResourceTest.put_entityUpdate_as_non_owner_4xx:924 expected: <Principal: CatalogPrincipal{name='test'} does not have permissions> but was: <Principal: CatalogPrincipal{name='test'} is not admin>
2022-03-02T07:54:21.1656406Z [ERROR]   MessagingServiceResourceTest>EntityResourceTest.put_entityUpdate_as_non_owner_4xx:924 expected: <Principal: CatalogPrincipal{name='test'} does not have permissions> but was: <Principal: CatalogPrincipal{name='test'} is not admin>
2022-03-02T07:54:21.1657559Z [ERROR]   PipelineServiceResourceTest>EntityResourceTest.put_entityUpdate_as_non_owner_4xx:924 expected: <Principal: CatalogPrincipal{name='test'} does not have permissions> but was: <Principal: CatalogPrincipal{name='test'} is not admin>
2022-03-02T07:54:21.1658175Z [ERROR] Errors: 
2022-03-02T07:54:21.1683647Z [ERROR]   DashboardServiceResourceTest>EntityResourceTest.put_entityCreate_as_owner_200:865->EntityResourceTest.updateAndCheckEntity:1467->EntityResourceTest.updateEntity:1366 » HttpResponse
2022-03-02T07:54:21.1684810Z [ERROR]   DatabaseServiceResourceTest>EntityResourceTest.put_entityCreate_as_owner_200:865->EntityResourceTest.updateAndCheckEntity:1467->EntityResourceTest.updateEntity:1366 » HttpResponse
2022-03-02T07:54:21.1685802Z [ERROR]   MessagingServiceResourceTest>EntityResourceTest.put_entityCreate_as_owner_200:865->EntityResourceTest.updateAndCheckEntity:1467->EntityResourceTest.updateEntity:1366 » HttpResponse
2022-03-02T07:54:21.1686770Z [ERROR]   PipelineServiceResourceTest>EntityResourceTest.put_entityCreate_as_owner_200:865->EntityResourceTest.updateAndCheckEntity:1467->EntityResourceTest.updateEntity:1366 » HttpResponse
2022-03-02T07:54:21.1687241Z [INFO] 
2022-03-02T07:54:21.1687480Z [ERROR] Tests run: 919, Failures: 4, Errors: 4, Skipped: 0
2022-03-02T07:54:21.1687699Z [INFO] 
2022-03-02T07:54:21.1759250Z [INFO] ------------------------------------------------------------------------

[harshach]

Updated the code to add another method in Authorizer interface

1. isOwner, returns false if the owner is not found
2. We want the services to be created by admin or bots only but admin can assign owners
3. Owners should be able to update etc..
4. currently in other entities such as tables, topics etc.. we allow users to update the table details and take ownership if no owner is set.
5. However services have clear ownership and should only be created by admins and if there is no owner is assigned services must be managed by admin / bot only.