Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #2857 - Adding UI support for glossary #3092

Merged
merged 22 commits into from Mar 7, 2022
Merged

Feat #2857 - Adding UI support for glossary #3092

merged 22 commits into from Mar 7, 2022

Conversation

darth-coder00
Copy link
Contributor

@darth-coder00 darth-coder00 commented Mar 3, 2022

Describe your changes :

Closes #2857

I worked on the adding support for Glossary from UI

Type of change :

  • New feature

Frontend Preview (Screenshots) :

Screenshot 2022-03-06 at 9 47 21 PM Screenshot 2022-03-06 at 9 47 51 PM Screenshot 2022-03-06 at 9 48 44 PM Screenshot 2022-03-06 at 9 49 06 PM

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t @Sachin-chaurasiya

<>
<h6 className="tw-heading tw-text-base">Configure Your Glossary</h6>
<div className="tw-mb-5">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashitk fix this text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to get proper content for this, will be fixed in next patch

@darth-coder00 darth-coder00 marked this pull request as ready for review March 6, 2022 07:49
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@darth-coder00 darth-coder00 self-assigned this Mar 6, 2022
@darth-coder00 darth-coder00 added this to In progress in Release 0.9.0 via automation Mar 6, 2022
@darth-coder00 darth-coder00 changed the title Issue 2857 Feat #2857 - Adding UI support for glossary Mar 6, 2022
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harshach harshach merged commit 4d09c16 into main Mar 7, 2022
Release 0.9.0 automation moved this from In progress to Done Mar 7, 2022
@harshach harshach deleted the issue-2857 branch March 7, 2022 05:34
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

UI implementation for Glossary
3 participants