Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google auth #3096

Merged
merged 4 commits into from Mar 3, 2022
Merged

Fix google auth #3096

merged 4 commits into from Mar 3, 2022

Conversation

darth-coder00
Copy link
Contributor

Describe your changes :

Closes #3059

I worked on the OIDC authenticator for google SSO

Type of change :

  • Bug fix
  • Improvement

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t @Sachin-chaurasiya

@darth-coder00 darth-coder00 self-assigned this Mar 3, 2022
@darth-coder00 darth-coder00 added this to In progress in Release 0.9.0 via automation Mar 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@darth-coder00 darth-coder00 merged commit 8ef6cb0 into main Mar 3, 2022
Release 0.9.0 automation moved this from In progress to Done Mar 3, 2022
@darth-coder00 darth-coder00 deleted the fix-google-auth branch March 3, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@darth-coder00 darth-coder00

Labels
None yet
Projects
No open projects
Release 0.9.0
Done
Milestone
Milestone 5 - 0.9.0 Release
Development

Successfully merging this pull request may close these issues.

Google Sign-In doesn't work in Chrome
2 participants
@darth-coder00 @Sachin-chaurasiya