Sql_alchemy_helper Engine fix #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbrull
approved these changes
Mar 3, 2022
|
Added a fix for isinstance error under database_common.py |
harshach
approved these changes
Mar 3, 2022
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
ayush-shah
added a commit
that referenced
this pull request
Mar 4, 2022
* Added connect_args and options for creation of engine * Added connect_args to profiler engine * Error fixed on database_common profiler - isinstance error type or tuple of types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
Added connect_args and options for the creation of engine
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers
@harshach @pmbrull