Fix #3080: Activity Feed: Blank feed on my-data page for updating user's role or team #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updating user's role or team
mithmatt
reviewed
Mar 4, 2022
| for (var thread : threads) { | ||
| feedDao.create(thread); | ||
| // Skip creating threads for user or team related changes for now | ||
| if (!Entity.USER.equals(changeEvent.getEntityType()) && !Entity.TEAM.equals(changeEvent.getEntityType())) { |
There was a problem hiding this comment.
Can we maintain a list of entities in Entity.java that we can grab with shouldDisplayEntityChangeOnFeed or something similar?
We need to avoid user, team, role, bot, policy
There was a problem hiding this comment.
Sounds good. I will work on updating the patch.
|
[catalog] Kudos, SonarCloud Quality Gate passed! |
mithmatt
reviewed
Mar 4, 2022
| // | ||
| // List of entities whose changes should not be published to the Activity Feed | ||
| // | ||
| public static final List<String> ACTIVITY_FEED_EXCLUDED_ENTITIES = List.of(USER, TEAM, ROLE, POLICY, BOTS); |
There was a problem hiding this comment.
Minor: this could be a Set/HashSet
mithmatt
approved these changes
Mar 4, 2022
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
|
Test failure is not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
See #3080
Type of change :
Checklist:
Reviewers