Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

column-issue-fixed #3138

Merged
merged 2 commits into from Mar 4, 2022
Merged

column-issue-fixed #3138

merged 2 commits into from Mar 4, 2022

Conversation

codingwithabhi
Copy link
Contributor

Describe your changes :

I worked on fixing column issue in salesforce.
fix #3137

Type of change :

  • Bug fix
  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.

Reviewers

@harshach @ayush-shah @pmbrull

@codingwithabhi codingwithabhi added this to In progress in Release 0.9.0 via automation Mar 4, 2022
@codingwithabhi codingwithabhi removed this from In progress in Release 0.9.0 Mar 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pmbrull
pmbrull approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! LGTM

@ayush-shah ayush-shah merged commit 40d3f5e into open-metadata:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Salesforce Ingestion fails for some column datatype.
3 participants
@codingwithabhi @pmbrull @ayush-shah