New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3140 UI Allow users to update teams based on updateTeams permission. #3141

Merged

Sachin-chaurasiya merged 2 commits into main from updateTeams-feature

Mar 4, 2022

Member

Sachin-chaurasiya commented Mar 4, 2022 •

edited

Closes #3140

Describe your changes :

I worked on issue #3140

Type of change :

Improvement
New feature

Frontend Preview (Screenshots) :

Checklist:

I have read the CONTRIBUTING document.
I have performed a self-review of my own.
I have tagged my reviewers below.
I have commented on my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00


          Fix #3140 UI Allow users to update teams based on updateTeams permiss…

4d068d5

…ion.

Sachin-chaurasiya requested review from shahsank3t and darth-coder00

March 4, 2022 09:55

Sachin-chaurasiya self-assigned this


          Fix Failing test

4fdc76e

darth-coder00 approved these changes

View reviewed changes

Contributor

darth-coder00 left a comment

LGTM!

sonarcloud bot commented Mar 4, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Sachin-chaurasiya merged commit e3001e5 into main

Sachin-chaurasiya deleted the updateTeams-feature branch

March 4, 2022 11:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment