New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2884 UI From Roles page, Admin should be able to assign the role to a team #3147

Merged

Sachin-chaurasiya merged 1 commit into main from issue-2884

Mar 4, 2022

Member

Sachin-chaurasiya commented Mar 4, 2022 •

edited

Closes #2884

Describe your changes :

I worked on issue #2884

Type of change :

Improvement
New feature

Frontend Preview (Screenshots) :

Checklist:

I have read the CONTRIBUTING document.
I have performed a self-review of my own.
I have tagged my reviewers below.
I have commented on my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00


          Fix #2884 UI From Roles page, Admin should be able to assign the role…

2f6b766

… to a team

Sachin-chaurasiya self-assigned this

Sachin-chaurasiya requested review from darth-coder00 and shahsank3t

March 4, 2022 14:49

sonarcloud bot commented Mar 4, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

darth-coder00 approved these changes

View reviewed changes

Contributor

darth-coder00 left a comment

LGTM!

Sachin-chaurasiya merged commit 875404f into main

Sachin-chaurasiya deleted the issue-2884 branch

March 4, 2022 15:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment