Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Query Parser #3154

Merged
merged 1 commit into from Mar 4, 2022
Merged

Fix: Query Parser #3154

merged 1 commit into from Mar 4, 2022

Conversation

ayush-shah
Copy link
Member

Describe your changes :

User was facing

    [2022-03-04 16:40:24,291] INFO     {metadata.ingestion.source.sql_source_common:33} - Table Scanned:
    [2022-03-04 16:40:24,291] ERROR    {metadata.ingestion.processor.query_parser:74} - strptime() argument 1 must be str, not datetime.datetime

Strptime expecting str got datetime fix

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach @pmbrull

@ayush-shah ayush-shah self-assigned this Mar 4, 2022
@ayush-shah ayush-shah added bug Something isn't working Ingestion labels Mar 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ayush-shah ayush-shah merged commit 0d1fa67 into main Mar 4, 2022
@ayush-shah ayush-shah deleted the query_parser-patch branch March 4, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ingestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants