Fix #3124: Activity Feed: Add support for deleting a post #3161

vivekratnavel · 2022-03-04T21:50:12Z

Describe your changes :

See #3124

Type of change :

Checklist:

I have read the CONTRIBUTING document.
I have performed a self-review of my own.
I have tagged my reviewers below.
I have commented on my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

github-actions · 2022-03-04T21:50:35Z

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/FeedRepository.java

mithmatt · 2022-03-05T00:01:26Z

catalog-rest-service/src/main/resources/json/schema/api/feed/createPost.json

+    },
+    "from": {
+      "description": "Name of the User posting the message",
+      "type": "string"


If all users are in OpenMetadata internal db, should we use user id?

Actually not. Let's keep them as user names which are supposed to be unique and human readable. One reason why to use UUID is to identify an instance of an entity uniquely (entity with same name can be created and hence name might not be unique) and when permanent links are needed.

harshach

Lets not merge the delete part before we make the permission checks to authorizer

vivekratnavel · 2022-03-05T21:29:16Z

@mithmatt @harshach Thank you for the reviews and feedback. I have delegated the authorization logic to the AuthZ.

I will continue to work on converting the type of post.from and thread.createdBy to UUID. Then, the createPost will only require a message and we will populate post.from as id of the logged in user (securityContext.getUserPrincipal().getName()).