Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Azure SSO Scopes #3176

Merged
merged 1 commit into from Mar 7, 2022
Merged

fix: Azure SSO Scopes #3176

merged 1 commit into from Mar 7, 2022

Conversation

akash-jain-10
Copy link
Collaborator

Describe your changes :

fixes #3175

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 4 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@harshach harshach merged commit df5ccc1 into main Mar 7, 2022
@harshach harshach deleted the fix/microsoft-sso-scopes branch March 7, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

@darth-coder00 darth-coder00 Awaiting requested review from darth-coder00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] [SSO] [Microsoft] MSAL Scopes should not contain user.read
2 participants
@akash-jain-10 @harshach