Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entity not found in Authorizer init #3177

Merged
merged 1 commit into from Mar 5, 2022
Merged

Fix entity not found in Authorizer init #3177

merged 1 commit into from Mar 5, 2022

Conversation

mithmatt
Copy link
Collaborator

@mithmatt mithmatt commented Mar 5, 2022 •
edited

Describe your changes :

I worked on this to fix an issue where Entity team is not found while running the app
ForceRegister team as work around for now

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@mithmatt mithmatt requested a review from harshach March 5, 2022 18:18
@mithmatt mithmatt changed the title Force register TeamRepository in Authorizer init Fix entity not found in Authorizer init Mar 5, 2022
@mithmatt
Copy link
Collaborator Author

mithmatt commented Mar 5, 2022

@harshach I tested this change with following steps manually:

For both NoopAuthorizer and DefaultAuthorizer

  1. Clean up db (no users)
  2. Start OM, ensure it does not crash due to entity not found and check if it starts correctly and ensure admins and bots are added
  3. Restart OM and ensure it does not crash due to entity not found

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 8 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@mithmatt
Copy link
Collaborator Author

mithmatt commented Mar 5, 2022

pytest failure on timeout .. See #3178

@mithmatt mithmatt merged commit 38e03f7 into open-metadata:main Mar 5, 2022
@mithmatt mithmatt deleted the team_entity_nf branch March 5, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@vivekratnavel vivekratnavel Awaiting requested review from vivekratnavel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mithmatt @harshach